Refactor ProducerFactory to use constant for repeated exception message #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kwonyonghyun Thanks for the PR. Could you add your name as an author to the class? |
|
Done :) I've added my name as an author to the ProducerFactory class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message "This factory does not support this method" was hardcoded twice in the production code of the ProducerFactory interface. By introducing the constant FACTORY_DOES_NOT_SUPPORT_METHOD, we eliminate this duplication, improve code maintainability, and ensure consistency. This change is particularly significant as it affects actual production code, not test code. Moreover, while currently used twice, this constant could potentially be reused in other parts of the codebase in the future, further justifying its creation and enhancing the overall code quality and future maintainability of the ProducerFactory and related classes.