No Issue : Refactor test codes and Remove useless full package name. #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sobychacko
requested changes
Oct 9, 2024
spring-kafka-test/src/main/java/org/springframework/kafka/test/utils/KafkaTestUtils.java
Show resolved
Hide resolved
artembilan
requested changes
Oct 9, 2024
spring-kafka-test/src/main/java/org/springframework/kafka/test/utils/KafkaTestUtils.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Remove useless full package name.
In the
MessagingMessageListenerAdapterclass,org.springframework.messaging.converter.MessageConversionExceptionis already imported. however, theMessageConversionExceptionwas declared with full package names.2. Refactor test codes
Many test classes don't use
KafkaTestUtils.consumerProps()andKafkaTestUtils.producerProps()even if they can.Also, test code for
KafkaStreamscan be integrated usingKafkaTestUtils.streamsProps().