Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3617 : Value parameters in ReactiveKafkaProducerTemplate should be nullable #3651

Merged
merged 3 commits into from
Dec 7, 2024
+6 −4
Merged

GH-3617 : Value parameters in ReactiveKafkaProducerTemplate should be nullable #3651

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18d87c8
add @Nullable parameter to send method
jukekxm Nov 25, 2024
62fa6af
change package for @nullable
jukekxm Nov 28, 2024
23cbff5
fix import order checkstyle
jukekxm Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .../src/main/java/org/springframework/kafka/core/reactive/ReactiveKafkaProducerTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.springframework.kafka.support.KafkaHeaders;
import org.springframework.kafka.support.converter.MessagingMessageConverter;
import org.springframework.kafka.support.converter.RecordMessageConverter;
import org.springframework.lang.Nullable;
import org.springframework.messaging.Message;
import org.springframework.util.Assert;

Expand All @@ -51,6 +52,7 @@
*
* @author Mark Norkin
* @author Adrian Chlebosz
* @author Juhyun Kim
*
* @since 2.3.0
*/
Expand Down Expand Up @@ -92,19 +94,19 @@ public <T> Mono<SenderResult<T>> sendTransactionally(SenderRecord<K, V, T> recor
return sendTransactionally.single();
}

public Mono<SenderResult<Void>> send(String topic, V value) {
public Mono<SenderResult<Void>> send(String topic, @Nullable V value) {
return send(new ProducerRecord<>(topic, value));
}

public Mono<SenderResult<Void>> send(String topic, K key, V value) {
public Mono<SenderResult<Void>> send(String topic, K key, @Nullable V value) {
return send(new ProducerRecord<>(topic, key, value));
}

public Mono<SenderResult<Void>> send(String topic, int partition, K key, V value) {
public Mono<SenderResult<Void>> send(String topic, int partition, K key, @Nullable V value) {
return send(new ProducerRecord<>(topic, partition, key, value));
}

public Mono<SenderResult<Void>> send(String topic, int partition, long timestamp, K key, V value) {
public Mono<SenderResult<Void>> send(String topic, int partition, long timestamp, K key, @Nullable V value) {
return send(new ProducerRecord<>(topic, partition, timestamp, key, value));
}

Expand Down
Loading