GH-948: Enhance LEFException with group.id #949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#948 For example, this can be used by the `DeadLetterPublishingRecoverer`'s destination resolver to choose a topic based on the group in addition to the information in the consumer record.
artembilan
requested changes
Jan 29, 2019
| * @return the group id. | ||
| * @since 2.2.4 | ||
| */ | ||
| public String getGroupId() { |
Member
There was a problem hiding this comment.
Still @Nullable?
As well an appropriate message in its Javadocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #948
For example, this can be used by the
DeadLetterPublishingRecoverer'sdestination resolver to choose a topic based on the group in addition
to the information in the consumer record.