GH-960: Seek-to-Current - commit recovered offset #961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artembilan
requested changes
Feb 12, 2019
Member
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
just only one polishing concern.
Otherwise the feature is cool.
I just haven't figured how to answer to that SO question...
| commitCallback = LOGGING_COMMIT_CALLBACK; | ||
| } | ||
| consumer.commitAsync(Collections.singletonMap(new TopicPartition(record.topic(), record.partition()), | ||
| new OffsetAndMetadata(record.offset() + 1)), commitCallback); |
Member
There was a problem hiding this comment.
Looks like TopicPartition and OffsetAndMetadata could be extracted as variables before if..else. We are going to use them in both cases anyway.
Resolves spring-projects#960 When the container is configured with `AckMode.MANUAL_IMMEDIATE`, the `SeekToCurrentErrorHandler` can be configured to commit the offset of a recovered record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #960
When the container is configured with
AckMode.MANUAL_IMMEDIATE, theSeekToCurrentErrorHandlercan be configured to commit the offset ofa recovered record.