Improve EmbeddedLdapServer Lifecycle Support

[etrandafir93]

Closes #1025

[jzheaux]

Thanks for the updates, @etrandafir93. Are you able to add tests? Specifically, it would be nice to test calling start() after using the static method and to test calling close().

[etrandafir93]

Thanks for the updates, @etrandafir93. Are you able to add tests? Specifically, it would be nice to test calling start() after using the static method and to test calling close().

That makes sense @jzheaux - I have added three tests now and I've tried to keep them relatively simple. In terms of asserting, I have only checked whether the port is opened or not. Do you agree with this, or should I try to come up with more elaborate tests?

[jzheaux]

Thanks, @etrandafir93, this is now merged into main.

[jzheaux]

Note that I added two commits. The first was to address checkstyle errors; in the future, you can run ./gradlew checkstyleMain checkstyleTest to find these before opening a PR.

The second was to restrict start from being called twice as I'd prefer to encourage a minimal amount of code in tests. If it becomes necessary to allow this later on, then we can remove the validation.