Sign assemblies with strong name #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion that are strong named can use spring.net
|
I think it should be enough to add this to shared https://github.com/spring-projects/spring-net/blob/main/src/Directory.Build.props ? |
|
Yes you are right, I changed that. |
lahma
changed the title
|
Thank you! |
|
Great, when will this be on NuGet? |
|
Impossible to say. I've again lost permissions to configure this repo's settings, but it should already be on MyGet feed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #212 and now Project that use strong name can use Spring.net
For more see: https://learn.microsoft.com/en-us/dotnet/standard/assembly/strong-named
I had to change one dependency(Experimental.System.Messaging) as it was also not strong named, but luckily there was a package in NuGet that was singed.