Skip to content

Commit

Permalink
Update to Brave 6.0.1
Browse files Browse the repository at this point in the history
This commit updates to the latest Brave version (6.0.1). This revealed a
strange classloader issue for Zipkin2.Span when running the failover
sample app during the 'test' target. To get around this issue the
tracing dependencies are temporarily commented out in the failover
sample app.
  • Loading branch information
onobc committed Feb 20, 2024
1 parent 2aecb93 commit 80fb829
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[versions]
# product
brave = "5.17.1"
brave = "6.0.1"
caffeine = "3.1.8"
jackson = "2.16.1"
jsr305 = "3.0.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ ext['pulsar.version'] = "${pulsarVersion}"
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-pulsar'
implementation 'org.springframework.boot:spring-boot-starter-actuator'
implementation 'io.micrometer:micrometer-tracing-bridge-brave'
implementation 'io.zipkin.reporter2:zipkin-reporter-brave'
implementation 'io.zipkin.reporter2:zipkin-sender-urlconnection'
// TODO add back in once samples are not run during part of the 'test' target
// implementation 'io.micrometer:micrometer-tracing-bridge-brave'
// implementation 'io.zipkin.reporter2:zipkin-reporter-brave'
// implementation 'io.zipkin.reporter2:zipkin-sender-urlconnection'
developmentOnly 'org.springframework.boot:spring-boot-docker-compose'

testImplementation project(':spring-pulsar-test')
Expand Down

0 comments on commit 80fb829

Please sign in to comment.