Add default hashCode implementation to RetryConfiguration.AnnotationClassOrMethodPointcut #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NorsaG Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@NorsaG Thank you for signing the Contributor License Agreement! |
artembilan
requested changes
Sep 23, 2024
src/main/java/org/springframework/retry/annotation/RetryConfiguration.java
Outdated
Show resolved
Hide resolved
NorsaG
force-pushed
the
AnnotationClassOrMethodPointcut-hashCode-implementation
branch
from
dfc2ee9 to
492e03d
Compare
…ssOrMethodPointcut
NorsaG
force-pushed
the
AnnotationClassOrMethodPointcut-hashCode-implementation
branch
from
80d4edf to
b4c9058
Compare
|
Fit the PR according to the comment. |
|
@NorsaG , thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a default implementation of
hashCodeforRetryConfiguration.AnnotationClassOrMethodPointcut.I discovered that using Spring Cloud with configuration refreshing (specifically the
@RefreshScopeannotation andConfigServicePropertySourceLocatoras part of spring-cloud-config) can lead to a "java.lang.OutOfMemoryError: Metaspace". This occurs because theConfigServicePropertySourceLocatoris re-initialized with every refresh. Due to the absence of ahashCodeimplementation, proxies for this class are regenerated each time, which causes them to be stored in theorg.springframework.cglib.core.internal.LoadingCache(withRetryConfiguration.AnnotationClassOrMethodPointcutbeing part of the composite key for this object).This results in an excessive accumulation of generated proxies in memory, ultimately leading to metaspace overflow.