-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequestMatcherDelegatingWebInvocationPrivilegeEvaluator doesn't provided access to the ServletContext #10779
Labels
in: web
An issue in web modules (web, webmvc)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Milestone
Comments
philwebb
added
status: waiting-for-triage
An issue we've not yet triaged
type: bug
A general bug
labels
Jan 25, 2022
jzheaux
added
in: web
An issue in web modules (web, webmvc)
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jan 25, 2022
marcusdacoregio
added a commit
that referenced
this issue
Jan 31, 2022
…ded access to the ServletContext Closes gh-10779
marcusdacoregio
added a commit
that referenced
this issue
Jan 31, 2022
…ded access to the ServletContext Closes gh-10779
marcusdacoregio
added a commit
that referenced
this issue
Jan 31, 2022
…ded access to the ServletContext Closes gh-10779
marcusdacoregio
added
for: backport-to-5.6.x
Designates an issue for backport to 5.6.x
status: backported
An issue that has been backported to maintenance branches
and removed
for: backport-to-5.6.x
Designates an issue for backport to 5.6.x
labels
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: web
An issue in web modules (web, webmvc)
status: backported
An issue that has been backported to maintenance branches
type: bug
A general bug
Describe the bug
See spring-projects/spring-boot#29564 for details.
The recently introduced
RequestMatcherDelegatingWebInvocationPrivilegeEvaluator
class creates a newFilterInvocation
in thegetDelegate
method. This invocation has aDummyRequest
which cannot provide access to theServletContext
. This means that Spring Boot'sApplicationContextRequestMatcher
cannot get theWebApplicationContext
.This feels quite similar to #10208 which was fixed by making the
WebInvocationPrivilegeEvaluator
ServletAware
.To Reproduce
Run tests from the sample application at https://github.com/jeffbswope/null-servletcontext-errorpagefilter
Expected behavior
The tests should pass
Sample
https://github.com/jeffbswope/null-servletcontext-errorpagefilter
The text was updated successfully, but these errors were encountered: