Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Option to Filter All Dispatcher Types #11092

Closed
marcusdacoregio opened this issue Apr 11, 2022 · 0 comments · Fixed by #11094
Closed

Add Option to Filter All Dispatcher Types #11092

marcusdacoregio opened this issue Apr 11, 2022 · 0 comments · Fixed by #11094
Assignees
@marcusdacoregio
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.7.0-RC1

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Apr 11, 2022 •
edited
Loading

Expected Behavior

The AuthorizationFilter and the DSL should have a property where users can set whether or not they want to apply the filter to all dispatcher types.

Current Behavior

Currently, FilterSecurityInterceptor and AuthorizationFilter only perform authorization checks on the first request. Authorization should be performed on dispatch.

NOTE: We may consider only making these changes to AuthorizationFilter rather than FilterSecurityInterceptor since we are moving towards using AuthorizationManager rather than the old authorization APIs.

Related:
@marcusdacoregio marcusdacoregio added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Apr 11, 2022
@marcusdacoregio marcusdacoregio added this to the 5.7.0-RC1 milestone Apr 11, 2022
@marcusdacoregio marcusdacoregio self-assigned this Apr 11, 2022
@marcusdacoregio marcusdacoregio changed the title Add the ability to filter on all Dispatcher Types Allow Choice to Filter All Dispatcher Types Apr 11, 2022
@marcusdacoregio marcusdacoregio changed the title Allow Choice to Filter All Dispatcher Types Allow Option to Filter All Dispatcher Types Apr 11, 2022
@marcusdacoregio marcusdacoregio changed the title Allow Option to Filter All Dispatcher Types Add Option to Filter All Dispatcher Types Apr 11, 2022
marcusdacoregio added a commit to marcusdacoregio/spring-security that referenced this issue Apr 11, 2022
@marcusdacoregio
Add Option to Filter All Dispatcher Types
c3fec35 
Closes spring-projectsgh-11092
@marcusdacoregio marcusdacoregio mentioned this issue Apr 11, 2022
Merged
@marcusdacoregio marcusdacoregio linked a pull request Apr 11, 2022 that will close this issue
Add Option to Filter All Dispatcher Types #11094
Merged
This was referenced Apr 13, 2022
Closed
Closed
marcusdacoregio added a commit that referenced this issue Apr 14, 2022
@marcusdacoregio
Add Option to Filter All Dispatcher Types
7fea639 
Closes gh-11092
@marcusdacoregio marcusdacoregio mentioned this issue Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-RC1
Development

Successfully merging a pull request may close this issue.

Add Option to Filter All Dispatcher Types marcusdacoregio/spring-security
1 participant
@marcusdacoregio