Skip to content

SAML Logout move onload script to body tag #11879

New issue
New issue
Closed
Closed
SAML Logout move onload script to body tag#11879
Assignees
marcusdacoregio
Labels
in: saml2An issue in SAML2 modulestype: bugA general bug
Milestone
5.8.0-RC1
@ugrave

Description

@ugrave
ugrave
opened on Sep 19, 2022

With PR #11676 the submit of the form was moved fron body to inline script. But it was no removed on all onLoad body tags:

spring-security/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2LogoutRequestFilter.java

Line 222 in e4e24c6

html.append(" <body onload=\"document.forms[0].submit()\">\n");

and

spring-security/saml2/saml2-service-provider/src/main/java/org/springframework/security/saml2/provider/service/web/authentication/logout/Saml2RelyingPartyInitiatedLogoutSuccessHandler.java

Line 126 in e4e24c6

html.append(" <body onload=\"document.forms[0].submit()\">\n");

still have the onLoad on the body and also now in the inlince script section.

Is there a reason/benefit to put the script outside of the head and body tag?

Metadata

Metadata

Assignees

Labels

in: saml2An issue in SAML2 modulestype: bugA general bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions