-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Closed
Labels
in: webAn issue in web modules (web, webmvc)An issue in web modules (web, webmvc)type: enhancementA general enhancementA general enhancement
Description
Under below condition, the method ignoresthis.useReferer
. I wonder if it is done on purpose.
isAlwaysUseDefaultTargetUrl()
is falsethis.targetUrlParameter
is not nullrequest.getParameter(this.targetUrlParameter)
is whitespace only
Would anyone help to check?
Lines 106 to 135 in 8aa7029
protected String determineTargetUrl(HttpServletRequest request, HttpServletResponse response) { | |
if (isAlwaysUseDefaultTargetUrl()) { | |
return this.defaultTargetUrl; | |
} | |
// Check for the parameter and use that if available | |
String targetUrl = null; | |
if (this.targetUrlParameter != null) { | |
targetUrl = request.getParameter(this.targetUrlParameter); | |
if (StringUtils.hasText(targetUrl)) { | |
if (this.logger.isTraceEnabled()) { | |
this.logger.trace(LogMessage.format("Using url %s from request parameter %s", targetUrl, | |
this.targetUrlParameter)); | |
} | |
return targetUrl; | |
} | |
} | |
if (this.useReferer && !StringUtils.hasLength(targetUrl)) { | |
targetUrl = request.getHeader("Referer"); | |
if (this.logger.isTraceEnabled()) { | |
this.logger.trace(LogMessage.format("Using url %s from Referer header", targetUrl)); | |
} | |
} | |
if (!StringUtils.hasText(targetUrl)) { | |
targetUrl = this.defaultTargetUrl; | |
if (this.logger.isTraceEnabled()) { | |
this.logger.trace(LogMessage.format("Using default url %s", targetUrl)); | |
} | |
} | |
return targetUrl; | |
} |
Metadata
Metadata
Assignees
Labels
in: webAn issue in web modules (web, webmvc)An issue in web modules (web, webmvc)type: enhancementA general enhancementA general enhancement