Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated SecurityContextPersistenceFilter from docs #12690

Closed
wiketool opened this issue Feb 17, 2023 · 2 comments
Closed

Remove deprecated SecurityContextPersistenceFilter from docs #12690

wiketool opened this issue Feb 17, 2023 · 2 comments
Assignees
@wiketool
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone
6.0.3

Comments

@wiketool
Copy link
Contributor

Expected Behavior
The Authentication is set on the SecurityContextHolder. Later, if you need to save SecurityContext , SecurityContextRepository#saveContext must be explicitly invoked.See the SecurityContextHolderFilter class.

Current Behavior
The Authentication is set on the SecurityContextHolder. Later, the SecurityContextPersistenceFilter saves the SecurityContext to the HttpSession. See the SecurityContextPersistenceFilter class.

link to related pages
@wiketool wiketool added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Feb 17, 2023
@wiketool wiketool changed the title Remove SecurityContextPersistenceFilter which has been Deprecated from docs [in docs] Remove SecurityContextPersistenceFilter which has been Deprecated from docs Feb 17, 2023
@sjohnr sjohnr added in: docs An issue in Documentation or samples status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2023
@sjohnr
Copy link
Member

sjohnr commented Feb 17, 2023

Thanks @wiketool! Let me know if you are interested in submitting a PR.

@sjohnr sjohnr changed the title [in docs] Remove SecurityContextPersistenceFilter which has been Deprecated from docs Remove deprecated SecurityContextPersistenceFilter from docs Feb 17, 2023
@sjohnr sjohnr added this to the 6.0.x milestone Feb 17, 2023
@baezzys baezzys mentioned this issue Feb 18, 2023
Closed
@wiketool wiketool mentioned this issue Feb 19, 2023
Closed
@wiketool
Copy link
Contributor Author

wiketool commented Feb 19, 2023 •
edited
Loading

Thanks @wiketool! Let me know if you are interested in submitting a PR.

Thank you @sjohnr ! I feel very proud to become a contributor Spring Security. I have made a pr in #12747.

wiketool added a commit to wiketool/spring-security that referenced this issue Feb 25, 2023
@wiketool
Correct deprecated description in docs
f7866b0 
Remove deprecated SecurityContextPersistenceFilter from docs.

Closes spring-projectsgh-12690
@sjohnr sjohnr removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Feb 28, 2023
@sjohnr sjohnr mentioned this issue Feb 28, 2023
Closed
@sjohnr sjohnr closed this as completed in 8b2ce79 Feb 28, 2023
@sjohnr sjohnr modified the milestones: 6.0.x, 6.0.3 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wiketool wiketool

Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.3
Development

No branches or pull requests
2 participants
@sjohnr @wiketool