Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PublicKeyCredentialRequestOptions Serializable #16432

Open
rwinch opened this issue Jan 16, 2025 · 1 comment · May be fixed by #16438
Open

Make PublicKeyCredentialRequestOptions Serializable #16432

rwinch opened this issue Jan 16, 2025 · 1 comment · May be fixed by #16438
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Jan 16, 2025

We should make PublicKeyCredentialRequestOptions implement Serializable. This will ensure that it an be persisted in distributed HttpSession setups.
@rwinch rwinch added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jan 16, 2025
@rwinch rwinch changed the title We should make PublicKeyCredentialRequestOptions implement Serializable Make PublicKeyCredentialRequestOptions Serializable Jan 16, 2025
franticticktick added a commit to franticticktick/spring-security that referenced this issue Jan 17, 2025
@franticticktick
Make PublicKeyCredentialRequestOptions Serializable
87e31a2 
Closes spring-projectsgh-16432

Signed-off-by: Max Batischev <mblancer@mail.ru>
@franticticktick franticticktick linked a pull request Jan 17, 2025 that will close this issue
Open
franticticktick added a commit to franticticktick/spring-security that referenced this issue Jan 17, 2025
@franticticktick
Make PublicKeyCredentialRequestOptions Serializable
6f3e2ac 
Closes spring-projectsgh-16432

Signed-off-by: Max Batischev <mblancer@mail.ru>
@franticticktick
Copy link
Contributor

Hi @rwinch , could you review the PR?

franticticktick added a commit to franticticktick/spring-security that referenced this issue Jan 20, 2025
@franticticktick
Make PublicKeyCredentialRequestOptions Serializable
24a3e46 
Closes spring-projectsgh-16432

Signed-off-by: Max Batischev <mblancer@mail.ru>
franticticktick added a commit to franticticktick/spring-security that referenced this issue Jan 20, 2025
@franticticktick
Make PublicKeyCredentialRequestOptions Serializable
d646106 
Closes spring-projectsgh-16432

Signed-off-by: Max Batischev <mblancer@mail.ru>
franticticktick added a commit to franticticktick/spring-security that referenced this issue Jan 20, 2025
@franticticktick
Make PublicKeyCredentialRequestOptions Serializable
c845b68 
Closes spring-projectsgh-16432

Signed-off-by: Max Batischev <mblancer@mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make PublicKeyCredentialRequestOptions Serializable franticticktick/spring-security
2 participants
@rwinch @franticticktick