Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML config does not apply request-handler-ref to CsrfAuthenticationStrategy #16801

Closed
sjohnr opened this issue Mar 21, 2025 · 0 comments
Closed

XML config does not apply request-handler-ref to CsrfAuthenticationStrategy #16801

sjohnr opened this issue Mar 21, 2025 · 0 comments
Assignees
@sjohnr
Labels
in: config An issue in spring-security-config type: bug A general bug
Milestone
6.3.9

Comments

@sjohnr
Copy link
Member

sjohnr commented Mar 21, 2025

Describe the bug
CsrfBeanDefinitionParser does not apply the value of request-handler-ref to the bean definition of CsrfAuthenticationStrategy.

Note: By contrast, CsrfConfigurer does apply the configured CsrfTokenRequestHandler to the default CsrfAuthenticationStrategy.

Expected behavior
CsrfBeanDefinitionParser applies the value of request-handler-ref to the bean definition of CsrfAuthenticationStrategy.
@sjohnr sjohnr added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Mar 21, 2025
@sjohnr sjohnr added this to the 6.3.9 milestone Mar 21, 2025
@sjohnr sjohnr removed the status: waiting-for-triage An issue we've not yet triaged label Mar 21, 2025
@sjohnr sjohnr self-assigned this Mar 21, 2025
@sjohnr sjohnr added the in: config An issue in spring-security-config label Mar 21, 2025
@sjohnr sjohnr moved this to Prioritized in Spring Security Team Mar 21, 2025
@sjohnr sjohnr mentioned this issue Mar 28, 2025
Closed
sjohnr added a commit that referenced this issue Mar 28, 2025
@sjohnr
Apply request-handler-ref to CsrfAuthenticationStrategy
b7df861 
Closes gh-16801
@sjohnr sjohnr closed this as completed in c84c438 Mar 28, 2025
@sjohnr sjohnr moved this from Prioritized to Done in Spring Security Team Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjohnr sjohnr

Labels
in: config An issue in spring-security-config type: bug A general bug
Projects
Spring Security Team
Status: Done
Milestone
6.3.9
Development

No branches or pull requests
1 participant
@sjohnr