Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create OpenID Connect Discovery Client #5543

Closed
jgrandja opened this issue Jul 19, 2018 · 4 comments
Closed

Create OpenID Connect Discovery Client #5543

jgrandja opened this issue Jul 19, 2018 · 4 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Jul 19, 2018

Create OpenID Connect Discovery Client which is capable of requesting Provider Metadata via the supplied issuer.

Related #5523, #5540, #5350

NOTE: There is existing logic for OpenID Connect Discovery in OidcConfigurationProvider. We should extract this logic to allow for re-use in Client and Resource Server.

@jgrandja jgrandja added New Feature in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 19, 2018
@jgrandja jgrandja added this to the 5.1.0.RC1 milestone Jul 19, 2018
@jgrandja jgrandja self-assigned this Jul 25, 2018
@jgrandja
Copy link
Contributor Author

We're going to hold off on this feature for 5.1. This branch contains this feature and we'll consider adding it in a later release.

@jgrandja jgrandja removed this from the 5.1.0.RC1 milestone Jul 26, 2018
@rwinch rwinch added type: enhancement A general enhancement and removed New Feature labels May 3, 2019
@jgrandja jgrandja added this to the General Backlog milestone May 21, 2019
@jgrandja jgrandja removed their assignment Jun 4, 2019
@pthorson
Copy link

pthorson commented Dec 2, 2019

Note: OidcConfigurationProvider moved to ClientRegistrations in 742716f

@jgrandja
Copy link
Contributor Author

jgrandja commented May 18, 2021

Closing as this feature is not needed at the moment.

@jgrandja jgrandja removed this from the General Backlog milestone May 18, 2021
@jgrandja jgrandja self-assigned this May 18, 2021
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed type: enhancement A general enhancement labels May 18, 2021
@nevmerzhitsky
Copy link

Sorry, why did you not include the OpenID Connect Discovery Client to the library? There is an automated way to take jwks_uri key from the URLs like oauth2/.well-known/openid-configuration by the lib to pass it into createRemoteJWKSet()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

4 participants