Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request cache that uses cookie #8034

Closed
eleftherias opened this issue Feb 28, 2020 · 3 comments · Fixed by #8653
Closed

Add request cache that uses cookie #8034

eleftherias opened this issue Feb 28, 2020 · 3 comments · Fixed by #8653
Assignees
@eleftherias @zeeshanadnan
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.4.0-RC1

Comments

@eleftherias
Copy link
Contributor

Summary

Currently we have the ability to store a user's initial request using HttpSessionRequestCache. This causes the HttpSession to be read on every request.
We should provide an alternative that stores the initial request in a cookie instead of in the HttpSession.
@eleftherias eleftherias added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Feb 28, 2020
@eleftherias eleftherias self-assigned this Feb 28, 2020
@zeeshanadnan
Copy link
Contributor

Hi @eleftherias hope you are doing well in these tough times. If no one is working on this issue i would like to give it a try.

@eleftherias
Copy link
Contributor Author

Thanks @zeeshanadnan! The issue is yours.

@zeeshanadnan zeeshanadnan mentioned this issue Jun 4, 2020
Merged
@zeeshanadnan
Copy link
Contributor

@eleftherias sorry for being late. I have submitted a pull request.

zeeshanadnan added a commit to zeeshanadnan/spring-security that referenced this issue Jul 1, 2020
@zeeshanadnan
Adds cookie based RequestCache
92b7a32 
fixes spring-projectsgh-8034
eleftherias pushed a commit that referenced this issue Jul 2, 2020
@zeeshanadnan @eleftherias
Adds cookie based RequestCache
9708a2d 
fixes gh-8034
@eleftherias eleftherias added this to the 5.4.0-RC1 milestone Jul 2, 2020
eleftherias added a commit that referenced this issue Jul 2, 2020
@eleftherias
Polish CookieRequestCache
4fb5ff3 
Issue gh-8034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

@zeeshanadnan zeeshanadnan

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-RC1
Development

Successfully merging a pull request may close this issue.

Adds cookie based RequestCache zeeshanadnan/spring-security
2 participants
@eleftherias @zeeshanadnan