Verify Samples in Build #10031
Merged
Verify Samples in Build #10031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
status: duplicate
jzheaux
requested changes
Jul 1, 2021
buildSrc/src/main/groovy/io/spring/gradle/RemoteProjectTask.groovy
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/io/spring/gradle/RemoteProjectTask.groovy
Outdated
Show resolved
Hide resolved
marcusdacoregio
force-pushed
the
gh-9846
branch
3 times, most recently
from
f82aa0e to
3ca272f
Compare
|
I've updated the PR with your suggestions @jzheaux. Can you review it again? Thanks! |
jzheaux
requested changes
Jul 6, 2021
buildSrc/src/main/groovy/io/spring/gradle/convention/VerifySamplesPlugin.groovy
Outdated
Show resolved
Hide resolved
|
Thanks for the review @jzheaux, I've updated the PR based on your suggestions. |
jzheaux
requested changes
Jul 26, 2021
There was a problem hiding this comment.
Nice, @marcusdacoregio! I've left my remaining feedback inline. Once those are addressed feel free to merge.
marcusdacoregio
force-pushed
the
gh-9846
branch
2 times, most recently
from
64a0e11 to
4878239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new Gradle task named
checkSampleswhich clones and performs a./gradlew checkon the Samples project.Adds a new job in the CI workflow which runs the new
checkSamplestask.Closes gh-9846