Fixes references to AuthenticationFailureEvent, which does not exist #10064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmitrilc Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@dmitrilc Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: docs
|
Thanks, @dmitrilc! Will you please squash your commits and reference the GitHub ticket in the resulting comment? Something like: Having a commit message like this will automatically close the issue upon merging. |
There was a problem hiding this comment.
@dmitrilc I've noticed a tiny thing that we could also fix. It's totally up to you if you want to fix it 😃
docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc
Outdated
Show resolved
Hide resolved
fix the name of the parameter, from failure to badCredentials Replaces AuthenticationFailureEvent Remove AuthenticationFailureEvent Reference Closes spring-projectsgh-10062
|
Thanks, @dmitrilc! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10062
Replaces references to AuthenticationFailureEvent, which does exist, with AbstractAuthenticationFailureEvent. in file docs/manual/src/docs/asciidoc/_includes/servlet/authentication/events.adoc
Replace reference to AuthenticationFailureEvent, which does not exist, with AuthenticationFailureBadCredentialsEvent(matches Kotlin version) in file docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc