Make AuthorizationGrantTypeConverter support custom grant type #10155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Hi, @jgrandja , @jzheaux , @eleftherias . |
|
Thanks for the PR @chenrujun. Please add a test and we'll get this merged. |
jgrandja
added
in: oauth2
|
@jgrandja. |
|
Hi, @jgrandja. Could you please merge this PR? |
jgrandja
changed the title
|
Thanks for the updates @chenrujun. This is now in main. |
|
@jgrandja, thank you. |
chenrujun
deleted the
make-ClientAuthenticationMethodConverter-support-self-defined-AuthorizationGrantType
branch
akohli96
pushed a commit
to akohli96/spring-security
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have requirement to support self-defined
AuthorizationGrantType.But the
AuthorizationGrantTypeConverterdoes not support self-definedAuthorizationGrantType.So I created this PR.
Here is our code bout self-defined
AuthorizationGrantType: https://github.com/Azure/azure-sdk-for-java/blob/c822f9da53ef9796e0ae302ade875f8ba7668998/sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/AADAuthorizationGrantType.java#L14-L15