Default principalClaimName to SUB #10217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Checkstyle doesn't like IDEA's reformat |
|
Thanks, @djechelon! To simplify future maintenance, will you please squash your commits? |
jzheaux
added
in: oauth2
JwtAuthenticationConverter#principalClaimName is never going to be null from now on
djechelon
force-pushed
the
bugfix/20214-principal-claim-name-null
branch
from
4d68d25 to
b372c2c
Compare
|
Yea. Amend simply pretended to work. So now you deserve a mandatory friday fun |
|
Thanks, @djechelon! I adjusted the commit message to work better with our automation, and now it's merged via 4302a86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #10214