Skip to content

Conversation

@xpmatteo
Copy link

Previously, the AuthnRequestsSigned attribute was not set in the
metadata xml that is produced by the Saml2 metadata filter. As a
result, the maintainers of the IDP I had to register with were rejecting
our application.

Now, the attribute is always set, namely to "true" if the asserting
party wants signed authentication requests, and false otherwise. This
declares to the asserting party whether authentication requests will be
signed or not.

Previously, the AuthnRequestsSigned attribute was not set in the
metadata xml that is produced by the Saml2 metadata filter.  As a
result, the maintainers of the IDP I had to register with were rejecting
our application.

Now, the attribute is always set, namely to "true" if the asserting
party wants signed authentication requests, and false otherwise. This
declares to the asserting party whether authentication requests will be
signed or not.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 18, 2021
@eleftherias eleftherias added in: saml2 An issue in SAML2 modules type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 21, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jan 14, 2022

Hi, @xpmatteo. Thanks for the contribution.

While I see your intent, I don't think we want to assume RP metadata based on AP metadata. Whether or not an RP will sign AuthnRequests stands somewhat independent from whether or not an AP wants them signed.

Instead, what about adding a Converter method that allows the EntityDescriptor to be edited before getting serialized, e.g. setEntityDescriptorCustomizer(Consumer<EntityDescriptorParameters> entityDescriptor)? This would be similar to OpenSaml4AuthenticationRequestResolver#setAuthnRequestCustomizer.

@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Jan 14, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Feb 15, 2022

Closed in favor of #10839

@jzheaux jzheaux closed this Feb 15, 2022
@jzheaux jzheaux added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: saml2 An issue in SAML2 modules status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants