Add SAML 2.0 Login and Logout XML Support #10685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusdacoregio
added
status: duplicate
marcusdacoregio
force-pushed
the
saml2-login-xml
branch
from
bf2eaf8 to
c99242d
Compare
jzheaux
requested changes
Jan 24, 2022
There was a problem hiding this comment.
Great, @marcusdacoregio! I've only left one comment inline since I think that comment has the potential to change a lot. Otherwise, please feel free to update the copyright years to 2022 and other typical hygiene.
...g/src/main/java/org/springframework/security/config/http/Saml2LoginBeanDefinitionParser.java
Outdated
Show resolved
Hide resolved
marcusdacoregio
force-pushed
the
saml2-login-xml
branch
from
c99242d to
5b7414b
Compare
jzheaux
requested changes
Feb 15, 2022
There was a problem hiding this comment.
Thanks, @marcusdacoregio! I've left some feedback inline.
Also, I'm wondering if you would consider adding SAML 2.0 Logout XML support while you are at it, possibly in a separate commit?
...g/src/main/java/org/springframework/security/config/http/Saml2LoginBeanDefinitionParser.java
Outdated
Show resolved
Hide resolved
config/src/main/resources/org/springframework/security/config/spring-security-5.7.rnc
Outdated
Show resolved
Hide resolved
config/src/main/resources/org/springframework/security/config/spring-security-5.7.rnc
Outdated
Show resolved
Hide resolved
config/src/main/resources/org/springframework/security/config/spring-security-5.7.rnc
Outdated
Show resolved
Hide resolved
marcusdacoregio
force-pushed
the
saml2-login-xml
branch
2 times, most recently
from
6356b66 to
b027737
Compare
marcusdacoregio
changed the title
jzheaux
approved these changes
Feb 28, 2022
marcusdacoregio
force-pushed
the
saml2-login-xml
branch
from
b027737 to
10df298
Compare
marcusdacoregio
force-pushed
the
saml2-login-xml
branch
from
10df298 to
61274ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-9012, gh-10842
Sample https://github.com/marcusdacoregio/spring-security-samples/tree/saml2-login-xml