Skip to content

Conversation

Enkosz
Copy link
Contributor

@Enkosz Enkosz commented Mar 25, 2022

This PR does the following:

  • Updated saganCreateRelease task with the new referenceDocUrl for reference documentation
  • Updated sagan plugin unit tests

Issue gh-11016

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 25, 2022
@marcusdacoregio marcusdacoregio self-assigned this Mar 25, 2022
@marcusdacoregio marcusdacoregio added status: duplicate A duplicate of another issue in: build An issue in the build type: bug A general bug labels Mar 25, 2022
@marcusdacoregio marcusdacoregio added this to the 5.7.0-RC1 milestone Mar 25, 2022
@marcusdacoregio marcusdacoregio removed the status: waiting-for-triage An issue we've not yet triaged label Mar 30, 2022
Copy link
Contributor

@marcusdacoregio marcusdacoregio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Enkosz, nice work.

Can you please squash your commits? And also at the end of the commit message, please add Closes gh-11016 instead of Issue gh-11016.

- Updated saganCreateRelease task with the new referenceDocUrl for reference documentation

Closes spring-projectsgh-11016
@Enkosz
Copy link
Contributor Author

Enkosz commented Apr 1, 2022

@marcusdacoregio done! Let me know if i need to fix something else, thank you!

@marcusdacoregio marcusdacoregio merged commit ea37364 into spring-projects:5.7.x Apr 1, 2022
@marcusdacoregio
Copy link
Contributor

Thanks very much, @Enkosz. This is now merged into main and 5.7.x and backported to 5.6.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: build An issue in the build status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants