LogoutPageGeneratingWebFilter should honor context path #11717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vanwobe Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@vanwobe Thank you for signing the Contributor License Agreement! |
jzheaux
requested changes
Aug 16, 2022
...test/java/org/springframework/security/web/server/ui/LogoutPageGeneratingWebFilterTests.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/server/ui/LogoutPageGeneratingWebFilter.java
Outdated
Show resolved
Hide resolved
jzheaux
added
status: duplicate
|
Thanks for the updates, @vanwobe. Instead of adding the closes message to a separate commit, will you please squash your commits so that the one commit has both the explanation of what it does as well as the closes message? You can see an example in our contribution guidelines. |
|
@vanwobe, I'm seeing several more commits. Would you like a hand at getting the number of commits down to one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes gh-11716