Skip to content

Add new interfaces for BREACH protection #11731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Add new interfaces for BREACH protection #11731

wants to merge 6 commits into from

Conversation

sjohnr
Copy link
Contributor

@sjohnr sjohnr commented Aug 19, 2022 •
edited
Loading

Draft 2

  • Add CsrfTokenRequestAttributeHandler and CsrfTokenRequestResolver interfaces
  • Add CsrfTokenRequestProcessor and XorCsrfTokenRequestProcessor classes
  • Move csrfRequestAttributeName to CsrfTokenRequestProcessor

Issue gh-4001

@sjohnr sjohnr added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Aug 19, 2022
@sjohnr sjohnr requested a review from rwinch August 19, 2022 19:24
@sjohnr sjohnr self-assigned this Aug 19, 2022
@sjohnr sjohnr marked this pull request as draft August 19, 2022 19:24
@sjohnr sjohnr mentioned this pull request Aug 23, 2022
Closed
@sjohnr sjohnr force-pushed the gh-4001-draft-2-interfaces branch 3 times, most recently from edea52c to 2fb4a97 Compare August 25, 2022 21:03
@sjohnr sjohnr force-pushed the gh-4001-draft-2-interfaces branch from 613e61b to 3f99688 Compare August 31, 2022 19:05
@sjohnr sjohnr force-pushed the gh-4001-draft-2-interfaces branch from 3f99688 to ea04988 Compare August 31, 2022 21:21
@sjohnr sjohnr force-pushed the gh-4001-draft-2-interfaces branch from ea04988 to 0c8ff77 Compare August 31, 2022 21:34
@sjohnr sjohnr removed the request for review from rwinch September 19, 2022 19:11
@sjohnr sjohnr mentioned this pull request Sep 29, 2022
Closed
@sjohnr sjohnr closed this Oct 3, 2022
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label Oct 3, 2022
@sjohnr
Copy link
Contributor Author

sjohnr commented Oct 3, 2022 •
edited
Loading

This was partially merged in 86fbb8d in gh-11781.

@sjohnr sjohnr deleted the gh-4001-draft-2-interfaces branch October 4, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sjohnr sjohnr

Labels

in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sjohnr