Skip to content

Conversation

mojavelinux
Copy link
Contributor

Update the generateAntora task in docs subproject to keep the prerelease segment other than -SNAPSHOT (e.g., -RC2) in the docs version. In other words:

name: ROOT
version: 6.0.0-RC2
prerelease: true

and

name: ROOT
version: 6.0.0
prerelease: '-SNAPSHOT'

Only the snapshot should claim the GA version.

@mojavelinux
Copy link
Contributor Author

This change will need to be propagated to each maintenance branch (5.6, 5.7, 5.8).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 25, 2022
@marcusdacoregio
Copy link
Contributor

Hi @mojavelinux, can you change the target branch to 5.6.x? We started to forward-port fixes from the oldest supported branch where the problem happens, which in this case is 5.6.x.

@mojavelinux
Copy link
Contributor Author

Sure thing. Stay tuned.

@mojavelinux mojavelinux force-pushed the generate-antora-unique-prereleases branch from dfb6952 to 681c073 Compare October 27, 2022 18:26
@mojavelinux mojavelinux changed the base branch from main to 5.6.x October 27, 2022 18:34
@mojavelinux
Copy link
Contributor Author

Done.

@marcusdacoregio marcusdacoregio added this to the 5.6.10 milestone Nov 1, 2022
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 1, 2022
@marcusdacoregio marcusdacoregio self-assigned this Nov 1, 2022
@marcusdacoregio marcusdacoregio merged commit e9db852 into spring-projects:5.6.x Nov 1, 2022
@marcusdacoregio
Copy link
Contributor

Thanks @mojavelinux, this is now merged into all supported branches

@mojavelinux
Copy link
Contributor Author

Thanks! And onward we go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: docs An issue in Documentation or samples type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants