Fix Delegation-based Strategy with OidcUserService/OidcReactiveOAuth2UserService examples #12281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
…UserService examples Fix examples not copying userNameAttributeName
daniel-shuy
changed the title
This was referenced Nov 24, 2022
|
@daniel-shuy just an update that I will revisit this in the coming week to get this merged, as I think improving the docs will help. See also this comment regarding the related enhancement. |
sjohnr
added
in: docs
|
Thanks @daniel-shuy! This is now merged via 488901d with minor polish 9751636. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples for Delegation-based Strategy with
OidcUserService/OidcReactiveOAuth2UserServiceis bugged. If theuserNameAttributeNameis overridden withspring.security.oauth2.client.provider.<provider>.user-name-attribute,SecurityContextHolder.getContext().getAuthentication().getName()will return the value ofsub(the default username attribute) regardless of what is set.This fixes the example by obtaining the username attribute from
OidcUserRequestand passing it to the newDefaultOidcUser.See gh-12275 for the original discussion.