Skip to content

Conversation

@1livv
Copy link
Contributor

@1livv 1livv commented Jan 31, 2023

closes gh-12604

@pivotal-cla
Copy link

@1livv Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@1livv Thank you for signing the Contributor License Agreement!

@1livv
Copy link
Contributor Author

1livv commented Jan 31, 2023

Would it be possible to have this merged in the 5.8.x branch alongside main even though it's a new feature ? We're still using spring 5

@jzheaux jzheaux self-assigned this Feb 2, 2023
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 2, 2023
@jzheaux jzheaux added this to the 6.1.0-M2 milestone Feb 2, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Feb 7, 2023

Sorry, @1livv, that I missed your earlier comment about 5.8. Generally, our policy is to only backport bugs to 5.8.

In the meantime, I believe you have the option to override the provider setting in RelyingPartyRegistration. Have you already tried that as a workaround?

@1livv
Copy link
Contributor Author

1livv commented Feb 8, 2023

Thanks for the workaround @jzheaux that works ? Do I need to make my PR against main now ?

@jzheaux
Copy link
Contributor

jzheaux commented Feb 15, 2023

Yes, @1livv, it would be best to rebase on main.

@1livv 1livv changed the base branch from 5.8.x to main February 19, 2023 14:46
@1livv
Copy link
Contributor Author

1livv commented Feb 19, 2023

@jzheaux rebased it

@jzheaux jzheaux removed this from the 6.1.0-M2 milestone Mar 20, 2023
@jzheaux jzheaux changed the title Added support for AuthnRequestsSigned setting Add support for AuthnRequestsSigned setting Mar 20, 2023
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Mar 20, 2023
@jzheaux jzheaux added this to the 6.1.0-M3 milestone Mar 20, 2023
@jzheaux jzheaux merged commit fd4541b into spring-projects:main Mar 20, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Mar 20, 2023

Thanks, @1liv! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for AuthnRequestsSigned setting

4 participants