Skip to content

Change TestingAuthenticationToken to Accept Collection GrantedAuthorities #12953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Change TestingAuthenticationToken to Accept Collection GrantedAuthorities #12953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df6c516
TestingAuthenticationToken takes broader collection type
lmartelli Mar 30, 2023
a56fa64
Fix Javadoc
Mar 31, 2023
5cd668c
Polish TestingAuthenticationToken
jzheaux Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...src/main/java/org/springframework/security/authentication/TestingAuthenticationToken.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

package org.springframework.security.authentication;

import java.util.Collection;
import java.util.List;

import org.springframework.security.core.GrantedAuthority;
Expand Down Expand Up @@ -47,7 +48,13 @@ public TestingAuthenticationToken(Object principal, Object credentials, String..
this(principal, credentials, AuthorityUtils.createAuthorityList(authorities));
}

public TestingAuthenticationToken(Object principal, Object credentials, List<GrantedAuthority> authorities) {
public TestingAuthenticationToken(Object principal, Object credentials,
List<? extends GrantedAuthority> authorities) {
this(principal, credentials, (Collection<? extends GrantedAuthority>) authorities);
}

public TestingAuthenticationToken(Object principal, Object credentials,
Collection<? extends GrantedAuthority> authorities) {
super(authorities);
this.principal = principal;
this.credentials = credentials;
Expand Down
2 changes: 1 addition & 1 deletion ...pringframework/security/test/context/support/WithAnonymousUserSecurityContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import org.springframework.security.core.context.SecurityContextHolderStrategy;

/**
* A {@link WithAnonymousUserSecurityContextFactory} that runs with an
* A {@link WithSecurityContextFactory} that runs with an
* {@link AnonymousAuthenticationToken}. .
*
* @author Rob Winch
Expand Down
2 changes: 1 addition & 1 deletion ...org/springframework/security/test/context/support/WithMockUserSecurityContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
import org.springframework.util.StringUtils;

/**
* A {@link WithUserDetailsSecurityContextFactory} that works with {@link WithMockUser}.
* A {@link WithSecurityContextFactory} that works with {@link WithMockUser}.
*
* @author Rob Winch
* @since 4.0
Expand Down
3 changes: 1 addition & 2 deletions .../springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
import org.springframework.util.StringUtils;

/**
* A {@link WithUserDetailsSecurityContextFactory} that works with {@link WithUserDetails}
* .
* A {@link WithSecurityContextFactory} that works with {@link WithUserDetails} .
*
* @author Rob Winch
* @since 4.0
Expand Down