Skip to content

Refactor for readability #13472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2023
Merged

Refactor for readability #13472

merged 5 commits into from
Aug 7, 2023

Conversation

limvik
Copy link
Contributor

@limvik limvik commented Jul 9, 2023

I refactored it like this

  1. Using putIfAbsent method instead of containsKey and put method of the Map.
  2. Using pattern matching for instanceof

I hope this helps improve readability.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 9, 2023
limvik added 3 commits July 17, 2023 22:15
@limvik
Refactor equals method
440417a 
To use the accessor method for username instead of directly accessing the attribute.
@limvik
Fix documentation typo
d60d638 
changed "user name" to "username"
@limvik
Refactor equals method
2e32236 
Using the accessor method for fields instead of directly access
@jzheaux jzheaux self-assigned this Aug 7, 2023
@jzheaux jzheaux removed the status: waiting-for-triage An issue we've not yet triaged label Aug 7, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 7, 2023
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 7, 2023
@jzheaux jzheaux modified the milestones: 6.2.0, 6.1.3 Aug 7, 2023
@jzheaux jzheaux merged commit bcd4dcc into spring-projects:6.1.x Aug 7, 2023
jzheaux added a commit that referenced this pull request Aug 7, 2023
@jzheaux
Update Copyright
8d4a024 
PR gh-13472
@jzheaux
Copy link
Contributor

jzheaux commented Aug 7, 2023

Thanks, @limvik! This is now merged into 6.1.x, and main.

@limvik limvik deleted the refactor branch August 14, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jzheaux jzheaux

Labels

in: core An issue in spring-security-core type: enhancement A general enhancement

Projects

None yet

Milestone

6.1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@limvik @jzheaux @spring-projects-issues