Skip to content

Conversation

FdHerrera
Copy link

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 25, 2024
@jzheaux jzheaux self-assigned this Jan 30, 2024
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: breaks-passivity A change that breaks passivity with the previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 30, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jan 30, 2024

@FdHerrera, would you please do me a favor and change your commit message to include the Closes keyword before the GitHub issue? Like this:

Add validation IpAddressMatcher

Closes gh-13621

This integrates with GH to close the issue once the commit is merged.

@FdHerrera FdHerrera force-pushed the feat/IpAddressMatcher-validation branch from bc9678f to 39db11b Compare January 30, 2024 22:37
@FdHerrera
Copy link
Author

@FdHerrera, would you please do me a favor and change your commit message to include the Closes keyword before the GitHub issue? Like this:

Add validation IpAddressMatcher

Closes gh-13621

This integrates with GH to close the issue once the commit is merged.

Hi @jzheaux , ofc, my bad.

Just updated the MR with the changes suggested in the commit message.

Ty for your help!

@jzheaux jzheaux merged commit c1adeef into spring-projects:main Jan 31, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Jan 31, 2024

Thanks, @FdHerrera, this is now merged into main

@FdHerrera FdHerrera deleted the feat/IpAddressMatcher-validation branch January 31, 2024 12:45
@jzheaux jzheaux added this to the 6.3.0-M2 milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web An issue in web modules (web, webmvc) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants