Skip to content

Implement customization of rolePrefix in LdapUserDetailsManager #14574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

Implement customization of rolePrefix in LdapUserDetailsManager #14574

merged 1 commit into from
Feb 28, 2024

Conversation

Haarolean
Copy link
Contributor

Resolves #2083

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2024
jzheaux
jzheaux requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Haarolean! In addition to the inline feedback, will you please add some tests to LdapUserDetailsManagerTests for the new feature? And, will you please squash and format any commits into a single commit like so:

Commit Title (for example, Add Customization of rolePrefix in LdapUserDetailsManager)

Closes gh-2083

(quite similar to what you have already, just shortening the title and adding the Closes phrase to the description)

@jzheaux jzheaux self-assigned this Feb 12, 2024
@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue in: ldap An issue in spring-security-ldap type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 12, 2024
@jzheaux jzheaux mentioned this pull request Feb 12, 2024
Closed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 26, 2024

Hi, @Haarolean, are you able to make the requested changes? I'm happy to help, if not.

@Haarolean
Copy link
Contributor Author

Hi, @Haarolean, are you able to make the requested changes? I'm happy to help, if not.

Hey, sure am! Been busy a bit lately, will push the changes today.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 27, 2024
@Haarolean
Copy link
Contributor Author

@jzheaux do we have any instructions on how to enable checkstyle properly? Having a hard time with checkstyle (as always) in spring projects, I've imported the etc/checkstyle/checkstyle.xml as a scheme into IDEA via chsckstyle plugin, but despite that some things like import ordering are not being fixed automatically.

@Haarolean Haarolean requested a review from jzheaux February 27, 2024 09:18
@jzheaux jzheaux removed the status: feedback-provided Feedback has been provided label Feb 28, 2024
@jzheaux jzheaux added this to the 6.3.0-M3 milestone Feb 28, 2024
@jzheaux jzheaux merged commit 1509a98 into spring-projects:main Feb 28, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Feb 29, 2024

Thanks again, @Haarolean! This is now merged into main, including one polish commit to restore the Acegi header (we only change the ones in the form 20xx-20yy for now).

@Haarolean
Copy link
Contributor Author

@jzheaux thank you! Didn't know about the header part.

@Haarolean Haarolean deleted the issues/2083 branch March 1, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Projects
None yet
Milestone
6.3.0-M3
Development

Successfully merging this pull request may close these issues.

SEC-1877: Allow injection of rolePrefix to LdapUserDetailsManager
3 participants
@Haarolean @jzheaux @spring-projects-issues