Add ContinueOnError Support for Failed Authentications #14591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Thanks, @CrazyParanoid! I've left some feedback for you inline. Will you please take a look?
Also, when you are ready, please squash all your changes into a single commit and see if you can shorten the title of the commit a bit, maybe something like:
"Add ContinueOnError Support For Failed Authentications
Closes gh-14521"
...ava/org/springframework/security/authentication/DelegatingReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/security/authentication/DelegatingReactiveAuthenticationManager.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/security/authentication/DelegatingReactiveAuthenticationManager.java
Show resolved
Hide resolved
...rg/springframework/security/authentication/DelegatingReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
...rg/springframework/security/authentication/DelegatingReactiveAuthenticationManagerTests.java
Outdated
Show resolved
Hide resolved
...rg/springframework/security/authentication/DelegatingReactiveAuthenticationManagerTests.java
Show resolved
Hide resolved
franticticktick
force-pushed
the
gh-14521
branch
from
2f31a95 to
2cabbd8
Compare
|
Maybe we should change the comments? The old description is no longer entirely complete. For example, describe the behavior with continueOnError true. |
|
Good point, @CrazyParanoid. Would you like to take a crack at updating the JavaDoc? If not, I can add it in a polish commit. |
jzheaux
added
in: core
franticticktick
force-pushed
the
gh-14521
branch
from
2cabbd8 to
9e2f34b
Compare
|
Added a comment and fixed the format. |
jzheaux
changed the title
jzheaux
changed the title
jzheaux
changed the title
franticticktick
force-pushed
the
gh-14521
branch
from
9e2f34b to
4dd79e2
Compare
|
Sorry, this is my first contribution, I didn’t pay attention to important points such as checkstyle and format. |
jzheaux
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continueOnError flag has been added to DelegatingReactiveAuthenticationManager
Closes gh-14521