Use SessionAuthenticationStrategy for Remember-Me authentication #15748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
type: enhancement
xhaggi
force-pushed
the
fix/rememeber-me-session-strategy
branch
4 times, most recently
from
5e86336 to
a9147d0
Compare
|
@jzheaux of course. I have added the unit test. |
spring-projects-issues
added
status: feedback-provided
jzheaux
approved these changes
Oct 14, 2024
xhaggi
force-pushed
the
fix/rememeber-me-session-strategy
branch
5 times, most recently
from
d3861e5 to
1717d59
Compare
|
BTW is there any chance that this will be backported to earlier versions? |
jzheaux
force-pushed
the
fix/rememeber-me-session-strategy
branch
from
1717d59 to
f48a277
Compare
|
Hi, @xhaggi, no, it's not likely, given that there is a behavioral change and a new public API. That said, what version were you hoping to backport it to and what is preventing you from upgrading? |
I was thinking of the last stable version 6.3.x.
Nothing, but we have to wait for the next stable 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in gh-2253, the
RememberMeAuthenticationFilterdoes not call the configuredSessionAuthenticationStrategyif there is one, and therefore concurrent session control does not work properly.This PR adapts the
RememberMeAuthenticationFilterso that it calls theSessionAuthenticationStrategyon successful authentication as theAbstractAuthenticationProcessingFilterdoes. The sharedSessionAuthenticationStrategyis then used in theRememberMeConfigurerto configure the filter like it is done inFormLoginConfigurer.Let me know if anything is missing!