Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken Resource Server Doc Links #15845

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix Broken Resource Server Doc Links #15845

merged 1 commit into from
Sep 26, 2024

Conversation

ngocnhan-tran1996
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 24, 2024
jzheaux
jzheaux requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the broken links, @ngocnhan-tran1996! I've left some feedback inline.

Also, will you please change your commit message to be more descriptive as this helps future research when there are bugs?

You might have your commit title be something like "Fix Broken Resource Server Doc Links"

docs/modules/ROOT/pages/servlet/oauth2/resource-server/jwt.adoc Outdated Show resolved Hide resolved
@jzheaux jzheaux self-assigned this Sep 26, 2024
@jzheaux jzheaux added the type: bug A general bug label Sep 26, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Sep 26, 2024
@jzheaux jzheaux added this to the 6.2.7 milestone Sep 26, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Sep 26, 2024

Thanks again for your help here, @ngocnhan-tran1996. In the future, will you please create a branch for your PRs? This helps when it comes to me pushing polishes or rebasing your PR on a different branch before merging.

It's no problem this time; I can merge this, cherry-pick to an earlier version, and then forward-port the changes. Just something to remember for the future.

@jzheaux jzheaux changed the title Update document Fix Broken Resource Server Doc Links Sep 26, 2024
@jzheaux jzheaux merged commit 4e2cb8b into spring-projects:main Sep 26, 2024
6 checks passed
@jzheaux jzheaux modified the milestones: 6.2.7, 6.4.0-RC1 Sep 26, 2024
@ngocnhan-tran1996
Copy link
Contributor Author

Thanks again for your help here, @ngocnhan-tran1996. In the future, will you please create a branch for your PRs? This helps when it comes to me pushing polishes or rebasing your PR on a different branch before merging.

It's no problem this time; I can merge this, cherry-pick to an earlier version, and then forward-port the changes. Just something to remember for the future.

I will create a new branch in the next contribute. Thanks for your advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples type: task A general task
Projects
None yet
Milestone
6.4.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@ngocnhan-tran1996 @jzheaux @spring-projects-issues