Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authRequest(Token) In HttpServletRequest #16445

Conversation

amm0124
Copy link

@amm0124 amm0124 commented Jan 19, 2025

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 19, 2025
Signed-off-by: amm0124 <amm012450@gmail.com>
@amm0124 amm0124 force-pushed the add-authRequest-HttpServletRequest branch from 8032e23 to d1dbcf3 Compare January 19, 2025 09:32
@rwinch
Copy link
Member

rwinch commented Jan 21, 2025

I'd prefer a solution that does not require users to know an HttpServletRequest attribute name. I'm closing this, but let's discuss a solution on the ticket that you logged.

NOTE: If you need this now, you can always extend UsernamePasswordAuthenticationFilter and override the setDetails method to set the attribute in the subclass.

@rwinch rwinch closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants