Polish AbstractAuthenticationTargetUrlRequestHandler #16557
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
franticticktick
force-pushed
the
polishhandler
branch
from
89249a9 to
94d2d0b
Compare
|
In your commit message, will you please add a link to this PR by doing: on its own line? This is helpful in case someone wants to read up on the rationale for the decision. Without it, it may be hard to find this conversation. |
PR spring-projectsgh-16557 Signed-off-by: Max Batischev <mblancer@mail.ru>
franticticktick
force-pushed
the
polishhandler
branch
from
94d2d0b to
f6514c4
Compare
|
Hi @jzheaux, thanks for your feedback, I added a link to this polish in the PR in the commit message. |
jzheaux
added
in: web
|
Thanks again, @franticticktick! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is small polish add assertion to
setRedirectStrategyofAbstractAuthenticationTargetUrlRequestHandlerto preventNullPointnerException.