Skip to content

Cleanup code #17142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

Cleanup code #17142

merged 2 commits into from
May 23, 2025

Conversation

ngocnhan-tran1996
Copy link
Contributor

@ngocnhan-tran1996 ngocnhan-tran1996 commented May 19, 2025

@jzheaux
Copy link
Contributor

jzheaux commented May 21, 2025

Thanks, @ngocnhan-tran1996. So they can be tracked with #16889, will you please separate the Spring Framework deprecations from the other changes and add the following to the end of that separate commit:

Issue gh-16889

@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the cleanup branch 2 times, most recently from f29d9be to 2142e71 Compare May 22, 2025 03:56
@ngocnhan-tran1996
Copy link
Contributor Author

@jzheaux

Thanks for your review. The gradle.properties file in the main branch is incorrect; I've updated it in the PR.

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Issue spring-projectsgh-16889

Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@jzheaux
Copy link
Contributor

jzheaux commented May 22, 2025

Thanks, @ngocnhan-tran1996, I've updated the gradle.properties file(s) separately.

@jzheaux jzheaux added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 23, 2025
@jzheaux jzheaux self-assigned this May 23, 2025
@jzheaux jzheaux added the in: core An issue in spring-security-core label May 23, 2025
@jzheaux jzheaux merged commit 8e2067b into spring-projects:main May 23, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented May 23, 2025

Thanks, @ngocnhan-tran1996! This is now merged into main.

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the cleanup branch May 25, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants