Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OAuth's RestTemplate and WebClient customizable #8624

Closed
wants to merge 1 commit into from
Closed

Make OAuth's RestTemplate and WebClient customizable #8624

wants to merge 1 commit into from

Conversation

bedla
Copy link
Contributor

@bedla bedla commented Jun 2, 2020 •
edited
Loading

Hi,
I have created PR which makes RestTemplate and WebClient used through OAuth2 module customizable (currently there are private instances created). It kind of solves #7027 .
Basically I found all spots where http-clients were created and made that API customizable. Please review the path I have chosen, if it is ok. I am open for any modification.
Next steps (WIP) on my side are javadoc and tests.
Thx,
Ivos

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 2, 2020
@bedla bedla changed the title WIP Make OAuth's RestTemplate and WebClient customizable Make OAuth's RestTemplate and WebClient customizable Jun 2, 2020
@bedla
Copy link
Contributor Author

bedla commented Jun 2, 2020 •
edited
Loading

test failing because of different version of nimbus have been released recently (see e09edf6)

method com.nimbusds.jose.proc.JWSVerificationKeySelector.getExpectedJWSAlgorithm() removed by https://bitbucket.org/connect2id/nimbus-jose-jwt/commits/88fa35c27a2a041a9614c2e502a0b24d8f242436#Lsrc/main/java/com/nimbusds/jose/proc/JWSVerificationKeySelector.javaF74

i have changed version of nimbus like in this PR #8622

@bedla bedla force-pushed the oauth-resttemplate-webclient-customizable branch from ebbf801 to 0ac851f Compare June 2, 2020 19:27
@jgrandja
Copy link
Contributor

jgrandja commented Jun 2, 2020 •
edited
Loading

Thanks for the PR @bedla. However, a Draft PR has recently been submitted for this #8588. I haven't had time to review it as of yet.

Also, I'm seeing 44 modified files in this PR which would make it very difficult and time consuming to review. It's recommended to put forth a Draft PR with minimal changes as a first step so we can get on the same page with proposed changes. I would still be willing to review this PR but the changes need to be reduced significantly so we can proceed with initial draft review.

@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 2, 2020
@jgrandja jgrandja self-assigned this Jun 2, 2020
@bedla
Copy link
Contributor Author

bedla commented Jun 3, 2020 •
edited
Loading

sure, i see. i will cut it into pieces and create chained PRs.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 3, 2020
@jgrandja
Copy link
Contributor

jgrandja commented Jun 3, 2020

@bedla

i will cut it into pieces and create chained PRs

Please create ONLY one Draft PR.

I would recommend that the PR demonstrate how a user would provide a customized RestTemplate and configure it via DefaultClientCredentialsTokenResponseClient.setRestOperations(). Let's work with this initially until we align on the approach. Afterwards, the rest can be implemented.

@jgrandja jgrandja added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jun 3, 2020
@bedla
Copy link
Contributor Author

bedla commented Jun 8, 2020 •
edited
Loading

@jgrandja Hi, I am unable to find IntelliJ Code format, is there any? (my default intellij formatter keeps changing to many unrelated lines)

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 8, 2020
@Budlee Budlee mentioned this pull request Jun 14, 2020
Closed
@bedla bedla mentioned this pull request Jun 14, 2020
Closed
@bedla
Copy link
Contributor Author

bedla commented Jun 14, 2020

FYI, I have created PR #8690 for changes related to JwtDecoders and ReactiveJwtDecoders.

@jgrandja
Copy link
Contributor

jgrandja commented Jun 15, 2020 •
edited
Loading

@bedla I'm closing this PR as per comment

@jgrandja jgrandja closed this Jun 15, 2020
@jgrandja jgrandja added status: duplicate A duplicate of another issue status: declined A suggestion or change that we don't feel we should currently apply and removed status: feedback-provided Feedback has been provided type: enhancement A general enhancement status: duplicate A duplicate of another issue labels Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bedla @jgrandja @spring-projects-issues