Skip to content

Conversation

tt4g
Copy link
Contributor

@tt4g tt4g commented Sep 16, 2020

The CSRF token is generated by UUID.randomUUID() which is I/O blocking operation.
This commit changes the subscriber thread to the bounded elactic scheduler.

Fix gh-9018

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 16, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Sep 16, 2020

Thanks for the PR, @tt4g! Will you please add the ticket number to the end your commit message like so:

...the bounded elactic scheduler.

Closes gh-9018

@jzheaux jzheaux changed the title Create the CSRF token on the bounded elactic scheduler Use Schedulers.boundedElastic for UUID.randomUUID Sep 16, 2020
@jzheaux jzheaux self-assigned this Sep 16, 2020
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 16, 2020
@tt4g
Copy link
Contributor Author

tt4g commented Sep 16, 2020

@jzheaux Thank you for quick response. I'm update commit message.

The CSRF token is generated by UUID.randomUUID() which is I/O blocking operation.
This commit changes the subscriber thread to the bounded elactic scheduler.

Closes spring-projectsgh-9018
@jzheaux jzheaux added this to the 5.5.0-M1 milestone Sep 16, 2020
@jzheaux jzheaux merged commit 2c297fb into spring-projects:master Sep 16, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Sep 16, 2020

Thanks, @tt4g, for the quick responses! This is now merged into master.

@jzheaux jzheaux modified the milestones: 5.5.0-M1, 5.4.1 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CookieServerCsrfTokenRepository#createNewToken should use Schedulers.boundedElastic

3 participants