Skip to content

Conversation

@b12f10w
Copy link

@b12f10w b12f10w commented Sep 20, 2020

I suggest SSL setup guide link from tomcat6 to tomcat10.
Tomcat 6 document for ssl (SSL is changed by SSL/TLS in tomcat 7,8,9,10 server document) is old.
So, I create pull request.

Also, I think it would better add xsd format in .ignore, So I suggest this file.

Regards.

@pivotal-issuemaster
Copy link

@b12f10w Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 20, 2020
@pivotal-issuemaster
Copy link

@b12f10w Thank you for signing the Contributor License Agreement!

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @b12f10w, thanks for the suggestion and the PR.

I've left some feedback inline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Spring Boot requires a minimum of Tomcat 9, I think it's best to point to the Tomcat 9. Would you please update this accordingly?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your comments. I will change this point.
Thank you.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completed fix my pull request as your comment.
Thanks.

.gitignore Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave this out of this PR. I'm thinking that we don't want to ignore .xsd files since we've got some in the repo, but if you feel like this change is necessary, please open a separate ticket.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your comments.
I will follow your comments.
Thank you.

Copy link
Author

@b12f10w b12f10w Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completed cancel my commit as your comment.
Thanks.

@jzheaux jzheaux self-assigned this Sep 22, 2020
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 22, 2020
@jzheaux jzheaux added this to the 5.4.1 milestone Sep 22, 2020
@b12f10w b12f10w force-pushed the master branch 2 times, most recently from f5e9c53 to d9b1615 Compare September 24, 2020 11:12
@jzheaux jzheaux merged commit c2d8939 into spring-projects:master Sep 24, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Sep 24, 2020

Thanks, @b12f10w! This is now merged into master.

@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants