Skip to content

Conversation

candrews
Copy link
Contributor

Performs a redirect to the original request URL when an invalid requested session is detected.

In effect, when a user's session times out, the user is redirected to URL they originally requested instead of some fixed URL.

I have a number of projects using this implementation, so I suspect it's useful to the wide Spring Security world.

I'm hoping you can give a quick review of this idea. If it seems like it will be acceptable to Spring Security, I'll update this PR with tests.

…dSessionStrategy

Performs a redirect to the original request URL when an invalid requested session is detected.

In effect, when a user's session times out, the user is redirected to URL they originally requested instead of some fixed URL.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 13, 2021
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall, I understand and agree with the proposal. I've provided feedback inline.

@candrews candrews requested a review from rwinch April 16, 2021 16:25
@candrews
Copy link
Contributor Author

Thank you for the review and feedback - I've addressed all of the feedback provided, so I think this PR is ready for another review.

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 16, 2021
@rwinch rwinch added this to the 5.6.0-M1 milestone Apr 20, 2021
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've scheduled it for 5.6.0-M1

@rwinch rwinch merged commit a7fbae8 into spring-projects:main May 26, 2021
@rwinch
Copy link
Member

rwinch commented May 26, 2021

Thanks for the Pull Request! This is now merged into main 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants