Add RequestedUrlRedirectInvalidSessionStrategy implemention of InvalidSessionStrategy #9632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dSessionStrategy Performs a redirect to the original request URL when an invalid requested session is detected. In effect, when a user's session times out, the user is redirected to URL they originally requested instead of some fixed URL.
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
requested changes
Apr 14, 2021
...ava/org/springframework/security/web/session/RequestedUrlRedirectInvalidSessionStrategy.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/security/web/session/RequestedUrlRedirectInvalidSessionStrategy.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/security/web/session/RequestedUrlRedirectInvalidSessionStrategy.java
Show resolved
Hide resolved
rwinch
reviewed
Apr 14, 2021
...ava/org/springframework/security/web/session/RequestedUrlRedirectInvalidSessionStrategy.java
Outdated
Show resolved
Hide resolved
|
Thank you for the review and feedback - I've addressed all of the feedback provided, so I think this PR is ready for another review. |
jzheaux
added
in: web
rwinch
approved these changes
Apr 20, 2021
|
Thanks for the Pull Request! This is now merged into main 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performs a redirect to the original request URL when an invalid requested session is detected.
In effect, when a user's session times out, the user is redirected to URL they originally requested instead of some fixed URL.
I have a number of projects using this implementation, so I suspect it's useful to the wide Spring Security world.
I'm hoping you can give a quick review of this idea. If it seems like it will be acceptable to Spring Security, I'll update this PR with tests.