Skip to content

Conversation

fhanik
Copy link
Contributor

@fhanik fhanik commented May 13, 2021

KeyInfo is typically provided as part of a SAML objects signature.

Example: https://login.run.pivotal.io/saml/metadata (check the child elements, //ds:Signature/ds:KeyInfo

Also mentioned on stack overflow: https://stackoverflow.com/questions/66369794/no-keyinfo-generator-provided-for-spring-security-saml2-service-provider

@jzheaux jzheaux self-assigned this May 13, 2021
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules type: enhancement A general enhancement labels May 13, 2021
@jzheaux jzheaux added this to the 5.6.0-M1 milestone May 13, 2021
@fhanik fhanik force-pushed the issue/saml_add_keyinfo_to_signature branch from d93d430 to 6b15f16 Compare May 13, 2021 17:57
@jzheaux
Copy link
Contributor

jzheaux commented Jun 7, 2021

Thanks, @fhanik, for the PR! This is now merged into main via adad2da. Because the directory structure was refactored since the PR was submitted, I also did a rebase in 8e0a91d

@jzheaux jzheaux closed this Jun 7, 2021
@surkoff-v
Copy link
Contributor

After this commit it has KeyInfo for AuthRequest but it still hasn't for Logout request initiated from RP side

@surkoff-v
Copy link
Contributor

surkoff-v commented Oct 22, 2021

After this commit it has KeyInfo for AuthRequest but it still hasn't for Logout request initiated from RP side

There are two versions org.springframework.security.saml2.provider.service.web.authentication.logoutOpenSamlSigningUtils and org.springframework.security.saml2.provider.service.web.authentication.logout.OpenSamlSigningUtils the first one has signingConfiguration.setKeyInfoGeneratorManager(buildSignatureKeyInfoGeneratorManager()); but the second don't. (5.6.0-RC1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: saml2 An issue in SAML2 modules type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants