Skip to content

Handle custom status codes in OAuth2ErrorResponseErrorHandler #9770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

Handle custom status codes in OAuth2ErrorResponseErrorHandler #9770

merged 1 commit into from
May 25, 2021

Conversation

@sjohnr
Copy link
Contributor

@sjohnr sjohnr commented May 18, 2021

Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.

Closes gh-9741

@sjohnr sjohnr requested a review from jgrandja May 18, 2021 16:43
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 18, 2021
@sjohnr sjohnr removed the request for review from jgrandja May 18, 2021 17:59
@sjohnr sjohnr added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels May 21, 2021
@jgrandja jgrandja added the type: bug A general bug label May 21, 2021
@jgrandja jgrandja added this to the 5.5.1 milestone May 21, 2021
jgrandja
jgrandja requested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sjohnr. Please see review comments.

@jgrandja jgrandja changed the title Handle custom status codes in error handler Handle custom status codes in OAuth2ErrorResponseErrorHandler May 25, 2021
@sjohnr sjohnr requested a review from jgrandja May 25, 2021 14:56
Handle custom status codes in error handler
36dcbe2 
Fixes an issue where custom status codes in the error response cause an
IllegalArgumentException to be thrown when resolving an HttpStatus.

Closes gh-9741
@sjohnr sjohnr merged commit 36dcbe2 into main May 25, 2021
@sjohnr sjohnr added the status: duplicate A duplicate of another issue label May 25, 2021
@sjohnr sjohnr deleted the gh-9741 branch May 25, 2021 18:52
@sjohnr sjohnr modified the milestones: 5.5.1, 5.6.0-M1 Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrandja jgrandja jgrandja approved these changes

Assignees

@jgrandja jgrandja

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Milestone

5.6.0-M1

Development

Successfully merging this pull request may close these issues.

OAuth2ErrorResponseErrorHandler throws IllegalArgumentException for a nonstandard HTTP status code response

3 participants

@sjohnr @jgrandja @spring-projects-issues