Skip to content

Conversation

frommeyerc
Copy link
Contributor

SecurityMockServerConfigurers.java previously used the StringUtils from
the optional oauth2-oidc-sdk dependency. Replacing this with the
StringUtils from the spring framework this should not force adding the
dependency in cases where it is not actually used.

Closes gh-9923

@pivotal-cla This is an Obvious Fix

SecurityMockServerConfigurers.java previously used the StringUtils from
the optional oauth2-oidc-sdk dependency. Replacing this with the
StringUtils from the spring framework this should not force adding the
dependency in cases where it is not actually used.

Closes spring-projectsgh-9923
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 16, 2021
@eleftherias eleftherias added in: test An issue in spring-security-test status: duplicate A duplicate of another issue type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 16, 2021
@jzheaux jzheaux added this to the 5.5.1 milestone Jun 16, 2021
@jzheaux jzheaux merged commit 8de631d into spring-projects:main Jun 16, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jun 16, 2021

Thanks for the PR, @frommeyerc! This is now merged into main and will be backported.

@jzheaux jzheaux modified the milestones: 5.5.1, 5.6.0-M1 Jun 16, 2021
giger85 added a commit to giger85/spring-security that referenced this pull request Feb 3, 2022
giger85 added a commit to giger85/spring-security that referenced this pull request Feb 3, 2022
eleftherias pushed a commit that referenced this pull request Feb 7, 2022
eleftherias pushed a commit that referenced this pull request Feb 7, 2022
eleftherias pushed a commit that referenced this pull request Feb 10, 2022
eleftherias pushed a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: test An issue in spring-security-test status: duplicate A duplicate of another issue type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using the SecurityMockServerConfigurers.java requires the com.nimbusds oauth2-oidc-sdk on the classpath

4 participants