Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoDB integration tests are failing #2118

Closed
vpavic opened this issue Aug 11, 2022 · 3 comments
Closed

MongoDB integration tests are failing #2118

vpavic opened this issue Aug 11, 2022 · 3 comments
Assignees
@rwinch
Labels
status: duplicate A duplicate of another issue type: bug A general bug

Comments

@vpavic
Copy link
Contributor

vpavic commented Aug 11, 2022

Some GitHub Actions runs where this happens:

The same issue happens for me locally.
@vpavic vpavic added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Aug 11, 2022
@vpavic
Copy link
Contributor Author

vpavic commented Aug 17, 2022 •
edited
Loading

This is apparently related to some recent changes in the Spring Security. If I set the Security dependency to 6.0.0-M6 then these tests are passing, but with 6.0.0-SNAPSHOT (which is what 3.0.x uses currently) they're failing.

@vpavic
Copy link
Contributor Author

vpavic commented Aug 17, 2022

This is due to spring-projects/spring-security#6613. I'm preparing the PR to adjust usage of Spring Security in various tests within the Spring Session codebase.

vpavic added a commit to vpavic/spring-session that referenced this issue Aug 17, 2022
@vpavic
Fix Spring Security configuration in tests
8c79920 
As of spring-projects/spring-security#11653, Spring Security's [at]Enable*Security annotations are not meta annotated with [at]Configuration which breaks some of our tests.

This commit adds missing [at]Configuration annotations where needed.

Closes spring-projectsgh-2118
@vpavic vpavic mentioned this issue Aug 17, 2022
Merged
rwinch pushed a commit that referenced this issue Aug 19, 2022
@vpavic @rwinch
Fix Spring Security configuration in tests
b85ec4d 
As of spring-projects/spring-security#11653, Spring Security's [at]Enable*Security annotations are not meta annotated with [at]Configuration which breaks some of our tests.

This commit adds missing [at]Configuration annotations where needed.

Closes gh-2118
@rwinch rwinch added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 19, 2022
@rwinch rwinch self-assigned this Aug 19, 2022
@rwinch
Copy link
Member

rwinch commented Aug 19, 2022

Closing in favor of gh-2125

@rwinch rwinch closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @vpavic