Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SameSite cookie directive #1132

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Jul 20, 2018

This is a WIP branch for #1005.

There are still some failing tests, due to pain of dealing with cookie directives that don't have support in Servlet spec (lik SameSite directive is), but please take a look on the general approach @rwinch.

@vpavic vpavic added type: enhancement A general enhancement in: core labels Jul 20, 2018
@vpavic vpavic added this to the 2.1.0.M1 milestone Jul 20, 2018
@vpavic vpavic requested a review from rwinch July 20, 2018 15:42
@vpavic
Copy link
Contributor Author

vpavic commented Jul 20, 2018

Note to self: Since we write Set-Cookie header manually, org.apache.tomcat.util.http.Rfc6265CookieProcessor#generateHeader is probably something worth looking at for reference.

@vpavic vpavic removed this from the 2.1.0.M1 milestone Jul 26, 2018
@vpavic vpavic added the status: duplicate A duplicate of another issue label Jul 26, 2018
@vpavic vpavic closed this Jul 30, 2018
@vpavic vpavic deleted the gh-1005 branch July 30, 2018 00:27
@vpavic vpavic removed type: enhancement A general enhancement in: core labels Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant