Harmonize Redis key namespace configurations #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, the RedisSessionRepository#setKeyNamespace expects users to provide the trailing colon (:) character that is used as separator between namespace segments. This is unlike RedisIndexedSessionRepository and ReactiveRedisSessionRepository that apply the separator implicitly in their respective #setRedisKeyNamespace methods. This commit harmonizes the Redis key namespaces configurations across all Redis-backed session repository implementations.
|
Thanks @vpavic! |
|
As labeled, this is IMO a bug and the change to address it is passive. If you're that concerned about the API change (or an addition, to be more precise) I'd suggest to do an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the
RedisSessionRepository#setKeyNamespaceexpects users to provide the trailing colon (:) character that is used as separator between namespace segments. This is unlikeRedisIndexedSessionRepositoryandReactiveRedisSessionRepositorythat apply the separator implicitly in their respective#setRedisKeyNamespacemethods.This PR harmonizes the Redis key namespaces configurations across all Redis-backed session repository implementations.
I've noticed this while applying the approach from #1710 in one project.
Ideally, this should be merged before #1710 which should then updated to pick up the new
#setRedisKeyNamespacemethod and use it in the sample.